Implement optimization to cast values instead of verifying the type#21627
Draft
Girgias wants to merge 2 commits intophp:masterfrom
Draft
Implement optimization to cast values instead of verifying the type#21627Girgias wants to merge 2 commits intophp:masterfrom
Girgias wants to merge 2 commits intophp:masterfrom
Conversation
ndossche
reviewed
Apr 4, 2026
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
It doesn't work because you need a result var. Furthermore the op handler destroys OP1 after setting the result, so they can't use the same TMP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came up with this idea while working on #21580,
but no idea if this is a safe way to write an optimizationclearly not because it seems to segfault everything.