Conversation
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughWorkspace-wide version bumps and new changelog entries across multiple crates; changelogs announce features (CLI Changes
Sequence Diagram(s)(omitted — changes are version/changelog updates without implemented control-flow changes) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
QaidVoid
force-pushed
the
release-plz-2026-02-26T07-27-16Z
branch
from
0c9629a to
dd1571f
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@crates/soar-core/CHANGELOG.md`:
- Around line 4-6: Update the changelog entry to explicitly call out the
breaking API changes: mention that the function substitute_placeholders had its
arity changed (update callers accordingly) and that a new public arch_map field
was added to the package-related types (ensure downstream code updates uses of
the affected structs/types). Reference the impacted symbols so maintainers can
find them: substitute_placeholders, and the newly exposed arch_map field on the
package/release source and install-related types (those changed in the
release_source and install modules). Add a short note that these are breaking
changes in the soar-core 0.15.0 entry so downstream crates can prepare necessary
code updates.
In `@crates/soar-package/CHANGELOG.md`:
- Line 6: The CHANGELOG entry contains a placeholder commit link "0000000" in
the line starting with "Updated the following local packages: soar-config -
([0000000]...)" which produces a broken link; replace "0000000" with the actual
commit hash that bumped soar-config (or remove the entire markdown link portion
"([0000000](...))" if the real commit is unknown), and apply the same
replacement/removal for any other entries using the same placeholder pattern
elsewhere in the changelog so all generated local-package bump lines contain
valid commit links or no link at all.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: db451f6d-b946-4bd9-ab52-31e4ca8b2cd9
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (15)
CHANGELOG.mdCargo.tomlcrates/soar-cli/Cargo.tomlcrates/soar-config/CHANGELOG.mdcrates/soar-config/Cargo.tomlcrates/soar-core/CHANGELOG.mdcrates/soar-core/Cargo.tomlcrates/soar-db/CHANGELOG.mdcrates/soar-db/Cargo.tomlcrates/soar-operations/CHANGELOG.mdcrates/soar-operations/Cargo.tomlcrates/soar-package/CHANGELOG.mdcrates/soar-package/Cargo.tomlcrates/soar-registry/CHANGELOG.mdcrates/soar-registry/Cargo.toml
🚧 Files skipped from review as they are similar to previous changes (7)
- crates/soar-config/Cargo.toml
- crates/soar-cli/Cargo.toml
- crates/soar-config/CHANGELOG.md
- crates/soar-operations/CHANGELOG.md
- crates/soar-registry/Cargo.toml
- CHANGELOG.md
- crates/soar-operations/Cargo.toml
Comment on lines
+4
to
+6
| ### ⛰️ Features | ||
|
|
||
| - *(packages)* Add arch_map for custom arch name mapping - ([61c0efb](https://github.com/pkgforge/soar/commit/61c0efb1e95127bde2574480a3971ff2f57e125a)) |
Contributor
There was a problem hiding this comment.
Call out the breaking API changes in this release note.
The PR metadata for soar-core 0.15.0 includes public API breaks, but this entry only reads as a feature addition. Please explicitly mention the substitute_placeholders arity change and the new public arch_map fields from crates/soar-core/src/utils.rs:97-110, crates/soar-core/src/package/release_source.rs:23-49, and crates/soar-core/src/package/install.rs:140-150, so downstream crates do not miss an upgrade that can require code changes.
📝 Suggested changelog addition
### ⛰️ Features
- *(packages)* Add arch_map for custom arch name mapping - ([61c0efb](https://github.com/pkgforge/soar/commit/61c0efb1e95127bde2574480a3971ff2f57e125a))
+
+### ⚠️ Breaking Changes
+
+- `substitute_placeholders` now takes an additional `arch_map` parameter, and public `arch_map` fields were added to `InstallTarget` and `ReleaseSource`.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| ### ⛰️ Features | |
| - *(packages)* Add arch_map for custom arch name mapping - ([61c0efb](https://github.com/pkgforge/soar/commit/61c0efb1e95127bde2574480a3971ff2f57e125a)) | |
| ### ⛰️ Features | |
| - *(packages)* Add arch_map for custom arch name mapping - ([61c0efb](https://github.com/pkgforge/soar/commit/61c0efb1e95127bde2574480a3971ff2f57e125a)) | |
| ### ⚠️ Breaking Changes | |
| - `substitute_placeholders` now takes an additional `arch_map` parameter, and public `arch_map` fields were added to `InstallTarget` and `ReleaseSource`. |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@crates/soar-core/CHANGELOG.md` around lines 4 - 6, Update the changelog entry
to explicitly call out the breaking API changes: mention that the function
substitute_placeholders had its arity changed (update callers accordingly) and
that a new public arch_map field was added to the package-related types (ensure
downstream code updates uses of the affected structs/types). Reference the
impacted symbols so maintainers can find them: substitute_placeholders, and the
newly exposed arch_map field on the package/release source and install-related
types (those changed in the release_source and install modules). Add a short
note that these are breaking changes in the soar-core 0.15.0 entry so downstream
crates can prepare necessary code updates.
69e1d04 to
fe9034e
Compare
Contributor
There was a problem hiding this comment.
♻️ Duplicate comments (1)
crates/soar-package/CHANGELOG.md (1)
6-6:⚠️ Potential issue | 🟡 MinorReplace placeholder commit link before publishing.
0000000is a dead reference, so this changelog line currently links to a non-existent commit.📝 Minimal fix
-- Updated the following local packages: soar-config - ([0000000](https://github.com/pkgforge/soar/commit/0000000)) +- Updated the following local packages: soar-config🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@crates/soar-package/CHANGELOG.md` at line 6, The CHANGELOG entry contains a placeholder commit link "([0000000](https://github.com/pkgforge/soar/commit/0000000))" which is a dead reference; update the line that reads "Updated the following local packages: soar-config - ([0000000](https://github.com/pkgforge/soar/commit/0000000))" by replacing 0000000 with the real commit SHA for the soar-config change (or remove the link entirely if no commit exists), ensuring the displayed SHA and URL match the actual commit hash.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@crates/soar-package/CHANGELOG.md`:
- Line 6: The CHANGELOG entry contains a placeholder commit link
"([0000000](https://github.com/pkgforge/soar/commit/0000000))" which is a dead
reference; update the line that reads "Updated the following local packages:
soar-config - ([0000000](https://github.com/pkgforge/soar/commit/0000000))" by
replacing 0000000 with the real commit SHA for the soar-config change (or remove
the link entirely if no commit exists), ensuring the displayed SHA and URL match
the actual commit hash.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 484338b4-cbe4-4c6c-98b2-3d14e774f3ff
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (17)
CHANGELOG.mdCargo.tomlcrates/soar-cli/Cargo.tomlcrates/soar-config/CHANGELOG.mdcrates/soar-config/Cargo.tomlcrates/soar-core/CHANGELOG.mdcrates/soar-core/Cargo.tomlcrates/soar-db/CHANGELOG.mdcrates/soar-db/Cargo.tomlcrates/soar-dl/CHANGELOG.mdcrates/soar-dl/Cargo.tomlcrates/soar-operations/CHANGELOG.mdcrates/soar-operations/Cargo.tomlcrates/soar-package/CHANGELOG.mdcrates/soar-package/Cargo.tomlcrates/soar-registry/CHANGELOG.mdcrates/soar-registry/Cargo.toml
✅ Files skipped from review due to trivial changes (4)
- crates/soar-config/Cargo.toml
- crates/soar-dl/Cargo.toml
- crates/soar-config/CHANGELOG.md
- crates/soar-operations/CHANGELOG.md
🚧 Files skipped from review as they are similar to previous changes (7)
- crates/soar-cli/Cargo.toml
- crates/soar-registry/CHANGELOG.md
- crates/soar-core/CHANGELOG.md
- crates/soar-package/Cargo.toml
- crates/soar-registry/Cargo.toml
- crates/soar-core/Cargo.toml
- crates/soar-db/CHANGELOG.md
QaidVoid
force-pushed
the
release-plz-2026-02-26T07-27-16Z
branch
from
fe9034e to
37e4442
Compare
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
crates/soar-db/CHANGELOG.md (1)
4-6: Consider semantic versioning for new features.The changelog documents a new feature (fuzzy search with "did you mean?" suggestions) under a patch version bump (0.5.0 → 0.5.1). Per semantic versioning conventions, new features typically warrant a minor version bump (e.g., 0.6.0), while patch versions are reserved for backward-compatible bug fixes.
If the fuzzy search feature is purely internal and doesn't affect the public API of
soar-db, then a patch version may be appropriate. Otherwise, consider whether this should be a minor version increment.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@crates/soar-db/CHANGELOG.md` around lines 4 - 6, The changelog entry adds a new feature (fuzzy search / "did you mean?") but is under a patch bump; either move this feature to a minor release entry or justify keeping it as a patch. Update the CHANGELOG.md for the crate (soar-db) to: a) change the release heading from a patch (e.g., 0.5.1) to the appropriate minor version (e.g., 0.6.0) if the feature changes the public API or is user-visible, or b) add a note explaining the feature is internal/backwards-compatible and therefore remains a patch; ensure the entry under "Features" reflects that decision and adjust the linked commit entry accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@crates/soar-db/CHANGELOG.md`:
- Around line 4-6: The changelog entry adds a new feature (fuzzy search / "did
you mean?") but is under a patch bump; either move this feature to a minor
release entry or justify keeping it as a patch. Update the CHANGELOG.md for the
crate (soar-db) to: a) change the release heading from a patch (e.g., 0.5.1) to
the appropriate minor version (e.g., 0.6.0) if the feature changes the public
API or is user-visible, or b) add a note explaining the feature is
internal/backwards-compatible and therefore remains a patch; ensure the entry
under "Features" reflects that decision and adjust the linked commit entry
accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 97ec59dd-4c5d-4bf4-95e7-872c9eff8df4
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (17)
CHANGELOG.mdCargo.tomlcrates/soar-cli/Cargo.tomlcrates/soar-config/CHANGELOG.mdcrates/soar-config/Cargo.tomlcrates/soar-core/CHANGELOG.mdcrates/soar-core/Cargo.tomlcrates/soar-db/CHANGELOG.mdcrates/soar-db/Cargo.tomlcrates/soar-dl/CHANGELOG.mdcrates/soar-dl/Cargo.tomlcrates/soar-operations/CHANGELOG.mdcrates/soar-operations/Cargo.tomlcrates/soar-package/CHANGELOG.mdcrates/soar-package/Cargo.tomlcrates/soar-registry/CHANGELOG.mdcrates/soar-registry/Cargo.toml
✅ Files skipped from review due to trivial changes (10)
- crates/soar-config/Cargo.toml
- crates/soar-cli/Cargo.toml
- crates/soar-dl/Cargo.toml
- crates/soar-operations/Cargo.toml
- crates/soar-registry/CHANGELOG.md
- crates/soar-operations/CHANGELOG.md
- crates/soar-db/Cargo.toml
- crates/soar-config/CHANGELOG.md
- crates/soar-core/CHANGELOG.md
- crates/soar-core/Cargo.toml
🚧 Files skipped from review as they are similar to previous changes (6)
- crates/soar-registry/Cargo.toml
- crates/soar-package/Cargo.toml
- crates/soar-dl/CHANGELOG.md
- Cargo.toml
- crates/soar-package/CHANGELOG.md
- CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 New release
soar-config: 0.6.0 -> 0.7.0 (⚠ API breaking changes)soar-dl: 0.9.0 -> 0.9.1 (✓ API compatible changes)soar-db: 0.5.0 -> 0.5.1 (✓ API compatible changes)soar-core: 0.14.0 -> 0.15.0 (⚠ API breaking changes)soar-operations: 0.1.0 -> 0.2.0 (⚠ API breaking changes)soar-cli: 0.12.0 -> 0.12.1soar-registry: 0.4.0 -> 0.4.1soar-package: 0.3.0 -> 0.3.1⚠
soar-configbreaking changes⚠
soar-corebreaking changes⚠
soar-operationsbreaking changesChangelog
soar-configsoar-dlsoar-dbsoar-coresoar-operationssoar-clisoar-registrysoar-packageThis PR was generated with release-plz.
Summary by CodeRabbit
New Features
soar repocommand for repository management with add, update, and remove operationsPerformance