Added public API for attaching/detaching a subcommand with an existing parser.#1623
Merged
kmvanbrunt merged 21 commits intomainfrom Apr 4, 2026
Merged
Added public API for attaching/detaching a subcommand with an existing parser.#1623kmvanbrunt merged 21 commits intomainfrom
kmvanbrunt merged 21 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1623 +/- ##
=======================================
Coverage 99.57% 99.57%
=======================================
Files 21 21
Lines 4721 4743 +22
=======================================
+ Hits 4701 4723 +22
Misses 20 20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tleonhardt
requested changes
Apr 3, 2026
tleonhardt
requested changes
Apr 4, 2026
| class of it. | ||
| - Removed `set_ap_completer_type()` and `get_ap_completer_type()` since `ap_completer_type` is | ||
| now a public member of `Cmd2ArgumentParser`. | ||
| - Moved `set_parser_prog()` to `Cmd2ArgumentParser.update_prog()`. |
Member
There was a problem hiding this comment.
Should we update anything in the documentation in relation to this PR? Perhaps in the migration guide for 4.x?
tleonhardt
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.