Disallow assignment of protocol or abstract classes to Callable#18347
Open
hauntsaninja wants to merge 2 commits intopython:masterfrom
Open
Disallow assignment of protocol or abstract classes to Callable#18347hauntsaninja wants to merge 2 commits intopython:masterfrom
hauntsaninja wants to merge 2 commits intopython:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
Prefect crash minimised is: |
Collaborator
Author
|
CPython is a true positive, you get a TypeError with: cloud-init is also arguably a true positive, since they're testing that it raises TypeError The diagnostics could be much better though. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
hauntsaninja
commented
Apr 4, 2026
3bd4914 to
8e8dc22
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: CPython (Argument Clinic) (https://github.com/python/cpython)
+ Tools/clinic/libclinic/cli.py:46: error: Incompatible types in assignment (expression has type "type[PythonLanguage]", target has type "Callable[[str], Language]") [assignment]
pandas (https://github.com/pandas-dev/pandas)
+ pandas/core/interchange/dataframe_protocol.py:368: error: Value of type variable "F" of function cannot be "type[DataFrame]" [type-var]
+ pandas/io/sas/sasreader.py:36: error: Value of type variable "F" of function cannot be "type[SASReader]" [type-var]
+ pandas/core/apply.py:83: error: Value of type variable "F" of function cannot be "type[BaseExecutionEngine]" [type-var]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://discuss.python.org/t/protocol-classes-should-not-match-callable-proto/75475