Open
Conversation
earthyoung
force-pushed
the
refactor/separate-common-package
branch
from
ccdf690 to
235fe79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
packages/common하위에 있는apis,hooks,schemas,utils,contexts디렉토리에 대해서 namespace를 제거하고 관련 import를 수정했습니다.단순 import만 수정한 파일들이 너무 많아서 리뷰를 요청드리기도 애매하네요... 수정 이후
pyconkr,pyconkr-admin,pyconkr-participant-portalapp 정상 동작하는 것 확인했습니다. 혹시 보시면서 수정이 필요한 부분 있으심 코멘트 주심 감사하겠습니다! 월요일(4/6) 중으로 없으시다면 PR 머지하면 어떨까요..!