[OpenVINOQuantizer] Fix Method to Obtain Quantization Parameters#18684
[OpenVINOQuantizer] Fix Method to Obtain Quantization Parameters#18684anzr299 wants to merge 5 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18684
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 2 Unrelated FailuresAs of commit b4e17de with merge base 6823b33 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
Fixes OpenVINO weight-compression observers to handle an NNCF API change where integer quantization now returns a structured object (quantization parameters), while attempting to preserve compatibility with older NNCF behavior.
Changes:
- Adds handling for
do_integer_quantization(...)returning aCompressedWeightobject (newer NNCF). - Adds fallback handling for legacy tuple return
(q_weight, scale, zp)(older NNCF). - Introduces a new import for
CompressedWeightto support the new return type.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
A recent change in NNCF functions to return quantization parameters breaks the OpenVINO quantizer observers.
This PR addresses the issue and also adds backwards support for this problem.