Skip to content

Disable im2row transform by default, add a flag to enable it (#18693)#18693

Merged
meta-codesync[bot] merged 1 commit intomainfrom
export-D97356070
Apr 4, 2026
Merged

Disable im2row transform by default, add a flag to enable it (#18693)#18693
meta-codesync[bot] merged 1 commit intomainfrom
export-D97356070

Conversation

@mcremon-meta
Copy link
Copy Markdown
Contributor

@mcremon-meta mcremon-meta commented Apr 3, 2026

Summary:

As titled. It typically hurts now that we have proper conv support:
{F1987095578}

This also introduces EdgePassesConfig to make it easier to do such things in the future. Details in https://docs.google.com/document/d/1c1mKse2-F1Ejh8Sg2pl-pBp3HZaIBdiUuhp86dyuEMA/edit?tab=t.0

Reviewed By: ethansfng

Differential Revision: D97356070

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Apr 3, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18693

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit a332f87 with merge base 6020c29 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 3, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync bot commented Apr 3, 2026

@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97356070.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync bot changed the title Disable im2row transform by default, add a flag to enable it Disable im2row transform by default, add a flag to enable it (#18693) Apr 3, 2026
meta-codesync bot pushed a commit that referenced this pull request Apr 3, 2026
Summary:

As titled. It typically hurts now that we have proper conv support:
{F1987095578}

This also introduces `EdgePassesConfig` to make it easier to do such things in the future. Details in https://docs.google.com/document/d/1c1mKse2-F1Ejh8Sg2pl-pBp3HZaIBdiUuhp86dyuEMA/edit?tab=t.0

Differential Revision: D97356070
@meta-codesync meta-codesync bot force-pushed the export-D97356070 branch from 463e40c to 9974e04 Compare April 3, 2026 20:24
mcremon-meta added a commit that referenced this pull request Apr 3, 2026
Summary:
Pull Request resolved: #18693

As titled. It typically hurts now that we have proper conv support:
{F1987095578}

This also introduces `EdgePassesConfig` to make it easier to do such things in the future. Details in https://docs.google.com/document/d/1c1mKse2-F1Ejh8Sg2pl-pBp3HZaIBdiUuhp86dyuEMA/edit?tab=t.0

Differential Revision: D97356070
Summary:

As titled. It typically hurts now that we have proper conv support:
{F1987095578}

This also introduces `EdgePassesConfig` to make it easier to do such things in the future. Details in https://docs.google.com/document/d/1c1mKse2-F1Ejh8Sg2pl-pBp3HZaIBdiUuhp86dyuEMA/edit?tab=t.0

Reviewed By: ethansfng

Differential Revision: D97356070
@meta-codesync meta-codesync bot force-pushed the export-D97356070 branch from e46b815 to a332f87 Compare April 4, 2026 05:49
@meta-codesync meta-codesync bot merged commit fb1618e into main Apr 4, 2026
164 of 168 checks passed
@meta-codesync meta-codesync bot deleted the export-D97356070 branch April 4, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants