fix: use unvalidated spec as fallback for canvas#9186
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if any canvas component had an invalid spec, the entire canvas dashboard became inaccessible in Rill Developer because
ResolveCanvasreturned early whencanvas.state.validSpecwas nil. This broke the editing workflow where a user intentionally changes ametrics_view(causing a transient error state) before selecting the correct fields.specinResolveCanvaswhenvalidSpecis nil, so the canvas shell remains accessible during mid-edit error statesBaseChart,CanvasPivot, andBaseCanvasComponentspec.rendererwhen reading component type incanvas-entity.tsandBaseChart/CanvasPivot, fixing a blank inspector panel when clicking a broken componentThe error/loading banner UX in
CanvasInitialization.svelteis unchanged — it still usesvalidSpecto drive reconcile error messaging correctly. This matches the fallback pattern already used inResolveTransitiveAccess(reconcilers/canvas.go:169-172).Checklist: