feat(ironclad): add Ironclad integration with OAuth#3795
feat(ironclad): add Ironclad integration with OAuth#3795waleedlatif1 wants to merge 8 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview Introduces an Ironclad block ( Extends the platform’s OAuth support to include Ironclad: new env vars ( Written by Cursor Bugbot for commit 5d7bad0. Configure here. |
Greptile SummaryThis PR adds a full Ironclad contract lifecycle management integration with 12 tools (workflow and record CRUD, approvals, and comments), OAuth 2.0 authentication, a block UI with conditional fields and wand configs, and documentation. The integration follows the established Sim integration patterns well. Previous review cycles resolved the key defects (unhandled
Confidence Score: 5/5Safe to merge — all P0/P1 issues from prior review rounds are resolved; remaining findings are P2 style/scope concerns. The three substantive defects from prior review cycles (unhandled JSON.parse crashes, ambiguous response field names, and defensive array parsing) were all fixed. The two remaining comments are P2: a hardcoded region that is a deliberate first-version scope decision, and a generationType annotation mismatch in a wand config. Neither blocks correctness for NA-region users. apps/sim/tools/ironclad/create_workflow.ts and apps/sim/lib/auth/auth.ts for the hardcoded na1 region; apps/sim/blocks/blocks/ironclad.ts for the generationType mismatch. Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant SimBlock as Ironclad Block
participant Framework as Sim Framework
participant IroncladAuth as Ironclad OAuth (na1)
participant IroncladAPI as Ironclad API (na1)
User->>SimBlock: Select operation + enter params
SimBlock->>Framework: Resolve oauthCredential → accessToken
Framework->>IroncladAuth: POST /oauth/token (refresh)
IroncladAuth-->>Framework: access_token
alt Create / Update / Cancel Workflow
Framework->>IroncladAPI: POST/PATCH/POST /public/api/v1/workflows/...
IroncladAPI-->>Framework: workflow JSON
else List / Get Workflow
Framework->>IroncladAPI: GET /public/api/v1/workflows[/{id}]
IroncladAPI-->>Framework: workflow list / detail JSON
else Record Operations
Framework->>IroncladAPI: POST/GET/PATCH /public/api/v1/records[/{id}]
IroncladAPI-->>Framework: record JSON
else Comments / Approvals
Framework->>IroncladAPI: GET/POST /public/api/v1/workflows/{id}/comments|approvals
IroncladAPI-->>Framework: comments / approvals JSON
end
Framework-->>SimBlock: Transformed output
SimBlock-->>User: Result
Reviews (6): Last reviewed commit: "lint" | Re-trigger Greptile |
…defensive response parsing
|
@greptile |
|
@cursor review |
|
@greptile |
|
@cursor review |
|
@greptile |
|
@cursor review |
|
@greptile |
|
@cursor review |
Summary
Type of Change
Testing
Tested manually
Checklist