web: pass Ctrl-= through to browser for font size increase#1713
web: pass Ctrl-= through to browser for font size increase#1713
Conversation
Agent-Logs-Url: https://github.com/solvespace/solvespace/sessions/5adeab0f-ee43-4436-afa4-2f332ce0eb7d Co-authored-by: phkahler <14852918+phkahler@users.noreply.github.com>
|
@copilot Why do you think CTRL - works but CRTL = need this change? |
The difference is in how each key is handled inside
} else if(event.chr == '=') {
// Treat = as +.
MenuView(Command::ZOOM_IN);
return true;
}This fires for both bare The fix in |
Ctrl-=(the no-Shift convention for Ctrl-plus) was intercepted by SolveSpace's canvas zoom-in handler, blocking the browser from using it to increase font size.Ctrl-minusalready passed through unblocked because the ZOOM_OUT accelerator is bound to bare-(no Ctrl), so the match failed andEM_FALSEwas returned — butCtrl-=had a special-case handler inGraphicsWindow::KeyboardEventthat matched regardless of Ctrl state.Change
Added an early-exit in
KeyboardCallback(guihtml.cpp) before any event processing:=without Ctrl continues to trigger canvas zoom-in as before.