Skip to content

chore: address commit comments for halfnormal logpdf#11290

Open
GuneetGill wants to merge 1 commit intostdlib-js:developfrom
GuneetGill:fix/halfnormal-logpdf-cleanup
Open

chore: address commit comments for halfnormal logpdf#11290
GuneetGill wants to merge 1 commit intostdlib-js:developfrom
GuneetGill:fix/halfnormal-logpdf-cleanup

Conversation

@GuneetGill
Copy link
Copy Markdown

Resolves #11289.

Description

What is the purpose of this pull request?

This pull request:

  • Updates the halfnormal/logpdf README so the distribution name follows project prose style (half-normal, not “Half-Normal”) in the linked intro line.
  • Migrates benchmark/benchmark.js to generate benchmark data with @stdlib/random/array/uniform instead of the older randu/manual array pattern.
  • Migrates benchmark/benchmark.native.js the same way, using uniform with { 'dtype': 'float64' } so the native benchmark matches current conventions used by similar packages (e.g. normal/logpdf).

These changes address the review comments on commit f4a07184f537ba8ef7928eb6cca51d0e1732f50e referenced in #11289.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

I used Cursor to understand the codebase to get a general sense of how the files I am touching work with one another. The code was written and tested by me.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Apr 4, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Apr 4, 2026
@github-actions github-actions bot mentioned this pull request Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Address commit comments (commit f4a0718)

2 participants