Conversation
GefMar
force-pushed
the
uv_integration
branch
from
34a1e08 to
4fd2ac2
Compare
GefMar
force-pushed
the
uv_integration
branch
2 times, most recently
from
fde4756 to
19fb288
Compare
pyproject.toml
Outdated
| [build-system] | ||
| requires = ["poetry-core>=1.0.0"] | ||
| build-backend = "poetry.core.masonry.api" | ||
| requires = ["uv_build>=0.9.16,<0.10.0"] |
There was a problem hiding this comment.
There is 0.11.3 version already: https://github.com/astral-sh/uv
Let's pin something like this requires = ["uv_build>=0.11.0,<0.12.0"]
pyproject.toml
Outdated
| ] | ||
| exclude = [".venv/"] | ||
| lint.mccabe = { max-complexity = 10 } | ||
| exclude = [".venv/"] |
There was a problem hiding this comment.
It's always excluded as far as you have it in .gitignore: https://docs.astral.sh/ruff/settings/#respect-gitignore
So you can delete this line completely
| with: | ||
| version: "latest" | ||
| enable-cache: true | ||
| cache-suffix: release-py3.14 |
There was a problem hiding this comment.
You can just specify python-version here instead of installing it in the next step: https://github.com/astral-sh/setup-uv#python-version
.github/workflows/test.yml
Outdated
| python-version: "3.11" | ||
| cache: "poetry" | ||
| persist-credentials: false | ||
| - uses: actions/setup-python@v5 |
There was a problem hiding this comment.
I think you don't need separate setup-python action. Because you already use astral-sh/setup-uv with python-version in the next step.
There was a problem hiding this comment.
This step is required — I checked it. Because UV_NO_MANAGED_PYTHON is used, uv sync cannot find a Python interpreter and the workflow fails.
.github/workflows/test.yml
Outdated
| run: poetry install --all-extras | ||
| env: | ||
| UV_NO_MANAGED_PYTHON: 1 | ||
| run: uv sync --all-extras --python 3.14 |
There was a problem hiding this comment.
No need to call uv sync with --python 3.14. astral-sh/setup-uv will put UV_PYTHON and uv will use it till the rest of this pipeline
There was a problem hiding this comment.
Am I correct in understanding that there is no need to use UV_NO_MANAGED_PYTHON?
fix: lint steps fix: uv build version update: Release workflow update: test workflow update: dependencies fix: lint fix: action update: git action del: poetry add: uv update: pre-commit hooks
3 participants
del: poetry
add: uv
update: pre-commit hooks