[INS-398] Added tests to ensure that custom endpoint configuration works in artifactory detectors#4832
Open
MuneebUllahKhan222 wants to merge 4 commits intotrufflesecurity:mainfrom
Open
Conversation
pkg/detectors/artifactoryreferencetoken/artifactoryreferencetoken_integration_test.go
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR adds test coverage for both Artifactory detectors by introducing:
for each detector.
The tests explicitly configure detector endpoints using
s.SetConfiguredEndpointsto ensure that:Purpose
Checklist:
make test-community)?make lintthis requires golangci-lint)?Note
Low Risk
Low risk because changes are limited to new unit/integration tests validating endpoint configuration behavior; no production detector logic is modified.
Overview
Adds new unit and integration tests for
artifactoryandartifactoryreferencetokendetectors that explicitly set endpoints viaSetConfiguredEndpointsand assert the configured endpoint is included inScanner.Endpoints()and in emittedResult.RawV2.Integration tests run
FromDatawith verification enabled and validate the detector uses the configured endpoint when forming the secret+endpoint pairing (including trimminghttps://for reference tokens).Written by Cursor Bugbot for commit 89069ae. This will update automatically on new commits. Configure here.