Skip to content

[ADD_RESOURCES_TO_BUILDNORMAL_PATH] - Added resolving of default maven resources#2734

Open
akoufoudakis wants to merge 2 commits intousethesource:mainfrom
akoufoudakis:ADD_RESOURCES_TO_BUILDNORMAL_PATH
Open

[ADD_RESOURCES_TO_BUILDNORMAL_PATH] - Added resolving of default maven resources#2734
akoufoudakis wants to merge 2 commits intousethesource:mainfrom
akoufoudakis:ADD_RESOURCES_TO_BUILDNORMAL_PATH

Conversation

@akoufoudakis
Copy link
Copy Markdown

This MR adds resolving of the default location of maven resources files.
The drawback of it is that when it is invoked through the util::Reflective::getProjectPathConfig, it "overrides" the configuration of the rascal-maven-plugin.

@akoufoudakis akoufoudakis marked this pull request as draft March 27, 2026 10:37
@akoufoudakis
Copy link
Copy Markdown
Author

@jurgenvinju Please, take a look.

@akoufoudakis akoufoudakis marked this pull request as ready for review March 27, 2026 10:40
@sonarqubecloud
Copy link
Copy Markdown

@DavyLandman
Copy link
Copy Markdown
Member

I think we should at least parse the maven file for the resource definition section. Since the rest of our data comes from the pom.xml.

@akoufoudakis
Copy link
Copy Markdown
Author

akoufoudakis commented Mar 30, 2026

@DavyLandman
We are talking about the resources inside the <configuration> of the rascal-maven-plugin, aren't we?

@DavyLandman
Copy link
Copy Markdown
Member

Well, I don't know.

  • our sources still flow from RASCAL.MF (which we want to get rid of)
  • maven has project.build.resources section
  • the rascal-maven plugin has a copy of the fields of the PathConfig

I think the idea of @jurgenvinju at the time was to use the rascal-maven-plugin configuration to define this, but we haven't specified how this goes for the evaluator.

My primary concern is that it shouldn't be hard coded in the PathConfig.java.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants