You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
this looks great, thanks for this. Instead of modifying the existing structured data type, can we make struct as a subclass of that data type, and register it? That means people who need the legacy dtype can still use it (by overriding the registry)
this looks great, thanks for this. Instead of modifying the existing structured data type, can we make struct as a subclass of that data type, and register it? That means people who need the legacy dtype can still use it (by overriding the registry)
❌ Patch coverage is 93.10345% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.88%. Comparing base (c9b534a) to head (5580194).
@d-v-b Is there anything I can do to move this PR forward?
hi @BrianMichell thanks for the ping, I will get a review in soon. since numpy is handling the actual data type, I think we will ask much less of you than the tensorstore devs :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates for consistency with the zarr-extension for structured types.
Implements legacy read-only for
structuredtype and support for newstructdefinition.TODO:
docs/user-guide/*.mdchanges/