tools: fix cpplint false positive for v8::FastApiCallbackOptions
Open
DivyanshuX9 wants to merge 1 commit intonodejs:mainfrom
Open
tools: fix cpplint false positive for v8::FastApiCallbackOptionsDivyanshuX9 wants to merge 1 commit intonodejs:mainfrom
DivyanshuX9 wants to merge 1 commit intonodejs:mainfrom
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i am trying to overcome this issue , #45761
My change Summary
cpplint's
runtime/referencesrule flags non-const reference parametersas a style violation. However,
v8::FastApiCallbackOptions&is part ofV8's Fast API contract , its signature is defined by V8 and Node.js has
no control over it. This causes a false positive.
Changes
Patched
CheckForNonConstReferenceintools/cpplint.pyto recognisev8::FastApiCallbackOptions&as a known V8 Fast API type thatlegitimately requires a non-const reference, and skip the warning for it.
Testing
Ran cpplint with
--filter=+runtime/referencesagainst a test filecontaining both patterns:
v8::FastApiCallbackOptions& options→ no warning (false positive suppressed)int& value→ still flagged (rule intact for legitimate cases )