Skip to content

tools: fix cpplint false positive for v8::FastApiCallbackOptions& #62585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DivyanshuX9 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

tools: fix cpplint false positive for v8::FastApiCallbackOptions& #62585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion tools/cpplint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6573,6 +6573,12 @@ def CheckForNonConstReference(filename, clean_lines, linenum, nesting_state, err
r"static_assert|COMPILE_ASSERT"
r")\s*\("
)

# V8 Fast API types require non-const references as part of their API
# contract; Node.js has no control over these signatures.
_V8_FAST_API_REF_TYPES = re.compile(
r"v8::FastApiCallbackOptions\s*&"
)
if re.search(allowed_functions, line):
return
if not re.search(r"\S+\([^)]*$", line):
Expand All @@ -6587,7 +6593,7 @@ def CheckForNonConstReference(filename, clean_lines, linenum, nesting_state, err
for parameter in re.findall(_RE_PATTERN_REF_PARAM, decls):
if not re.match(_RE_PATTERN_CONST_REF_PARAM, parameter) and not re.match(
_RE_PATTERN_REF_STREAM_PARAM, parameter
):
) and not _V8_FAST_API_REF_TYPES.search(parameter):
error(
filename,
linenum,
Expand Down
Loading